Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: move to useMutation for update channel notification API #105

Merged
merged 6 commits into from
Oct 23, 2023
Merged

REFACTOR: move to useMutation for update channel notification API #105

merged 6 commits into from
Oct 23, 2023
+6 −0

Conversation

madjiebimaa
Copy link
Contributor

@madjiebimaa madjiebimaa commented Oct 20, 2023 •
edited by mazipan
Loading

Closes #112

Description

Find a list of APIs that use the method PUT/PATCH/POST and have additional conditions (success, error, etc) or need some results (isLoading, etc). APIs that have those criteria will be added a layer before accessing those APIs directly with useMutation.

Current Tasks

APIs:

  • Check the slug owner (POST)
  • Update user (PATCH)
  • Send question (POST)
  • Add new custom og (POST)
  • Update custom og (PATCH)
  • Add new channel notification (POST)
  • Update channel notification (PATCH)

@vercel
Copy link

vercel bot commented Oct 20, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.

@mazipan first needs to authorize it.

@mazipan
Copy link
Owner

mazipan commented Oct 20, 2023 •
edited
Loading

If it's too big, let's make it smaller by merging one by one.

Wdyt? @madjiebimaa

I will create separate issue for each API, so you can create separate PR based on that

@madjiebimaa
Copy link
Contributor Author

If it's too big, let's make it smaller by merging one by one.

Wdyt? @madjiebimaa

I will create separate issue for each API, so you can create separate PR based on that

so rather than having several commits in one pull request, it would be good things if I create one commit for one pull request?

@mazipan
Copy link
Owner

mazipan commented Oct 20, 2023

Yes, I prefer to make it smaller.
It will be easier to review also for me.

@madjiebimaa madjiebimaa marked this pull request as ready for review October 20, 2023 13:38
@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanyaaja ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:42pm

@mazipan
Copy link
Owner

mazipan commented Oct 23, 2023

Conflict ya @madjiebimaa

@madjiebimaa
Copy link
Contributor Author

Conflict ya @madjiebimaa

Okay mas, I try to resolve this

@mazipan mazipan added hacktoberfest-accepted automerge Kodak's Auto Merge Label labels Oct 23, 2023
@kodiakhq kodiakhq bot merged commit 538f52b into mazipan:master Oct 23, 2023
2 checks passed
@madjiebimaa madjiebimaa deleted the refactor/move-to-usemutation branch October 23, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan approved these changes

Assignees
No one assigned
Labels
automerge Kodak's Auto Merge Label hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useMutation - Update channel notification (PATCH)
2 participants
@madjiebimaa @mazipan